Refactor change.py

This commit is contained in:
Patrick Elmer 2023-05-13 12:08:27 +09:00
parent d80081c214
commit b0dfd43495

View File

@ -80,13 +80,10 @@ def apply(
changes = [changes]
return_str = isinstance(strings, str)
if isinstance(strings, str):
strings = [strings]
else:
strings = strings.copy()
strings = [strings] if isinstance(strings, str) else strings.copy()
for change in changes:
if is_valid_change(change, ignore_errors=ignore_errors) == False:
if not is_valid_change(change, ignore_errors=ignore_errors):
continue
change = reformat_change_to_regex(change, categories=categories, zero_characters=zero_characters)
@ -114,7 +111,7 @@ def is_valid_change(change, ignore_errors=True):
valid = re.search(r'^[^>_/]+?>[^>_/]*?/?(:?[^>_/]*?_+[^>_/]*)?$', change)
if ignore_errors:
return valid != None
return valid is not None
if not valid:
raise ValueError(f"Change {change} is not a valid sound change.")
return True
@ -167,10 +164,7 @@ def split_change(change):
environment = re.sub('_+', '_', environment)
original, change_to = change.split('>')
if '_' in environment:
before, after = environment.split('_')
else:
before = after = ''
before, after = environment.split('_') if '_' in environment else ('', '')
return (original, change_to, before, after)